Fix import custom Nblts and added create_template#34
Merged
Conversation
- fix in read_modules.py for folder traversal not picking up modules. - added create_template to create more usable notebooklet template in template.py - updated nb_template.py to produce fake output - updating .pylintrc to remove deprecated warnings
- adding template.py with create_template function - added sections to creatingnotebooklets.rst for creating and import notebooklets. - Fixing sphinx errors in documents - Missing reference to URLSummary.rst - Fixing docstrings in account_summary.py and data_providers.py
- bypass passv_dns check in ip_summary.py if no suitable TI query/provider is available - fixed issue with Synapse module paths in read_modules.py - moved discover_modules to init function in __init__.py - otherwise a broken notebooklet would stop the whole thing from importing. Implemented ISort and Black on prod and test files. Added some pylint suppressions or fixes to url_summary.py
petebryan
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in template.py