chore: remove unused eslint-disable directives #35518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
requested review from
a team,
Jahnp,
ThomasMichon,
bigbadcapers,
dzearing and
khmakoto
as code owners
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
dmytrokirpa
approved these changes
Nov 25, 2025
![github-actions[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Remove unused eslint-disable comments that were flagged by ESLint's reportUnusedDisableDirectives setting. These directives were no longer needed as the underlying code no longer violates the disabled rules. Changes include: - Removed @typescript-eslint/no-deprecated disables where JSXElement is no longer deprecated - Removed @typescript-eslint/naming-convention disables where naming is compliant - Removed @fluentui/max-len disables where lines are within limits - Removed react-hooks/rules-of-hooks disables where hooks are used correctly - Cleaned up prefer-const disables where const is now properly used - Removed @fluentui/no-context-default-value and @fluentui/ban-context-export disables - Updated math operations to use ** operator instead of Math.pow Files affected: - packages/react-experiments (FloatingSuggestions, Persona, Tile, UnifiedPicker, etc.) - packages/react (tests and components) - packages/react-file-type-icons - packages/react-hooks - packages/react-window-provider - packages/utilities
mainframev
force-pushed
the
chore/remove-redundant-eslint-disables
branch
from
36b8aa0 to
75225fd
Compare
mainframev
added a commit
to mainframev/fluentui
that referenced
this pull request
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused eslint-disable comments that were flagged by ESLint reportUnusedDisableDirectives setting. These directives were no long needed as the underlying code no longer violates the disabled rules.
Changes include:
- Removed @typescript-eslint/no-deprecated disables where JSXElement is no longer deprecated (all ignores related to JSXElement are not relevant anymore, since they were introduced to JSX.Element in #34643
- Removed @typescript-eslint/naming-convention disables where naming is compliant
- Removed @fluentui/max-len disables where lines are within limits
- Removed react-hooks/rules-of-hooks disables where hooks are used correctly
- Removed @fluentui/no-context-default-value and @fluentui/ban-context-export disables
- Updated math operations to use ** operator instead of Math.pow