Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Move HasValidWebExperiencePack from DashboardViewModel to WidgetHostingService#2042

Merged
krschau merged 2 commits intofeature/win10from
krschau/win10-moveWebExpCheck
Dec 13, 2023
Merged

Move HasValidWebExperiencePack from DashboardViewModel to WidgetHostingService#2042
krschau merged 2 commits intofeature/win10from
krschau/win10-moveWebExpCheck

Conversation

@krschau
Copy link
Collaborator

@krschau krschau commented Dec 12, 2023

Summary of the pull request

Moves and simplifies some code in preparation for more changes going on top.

  • Moves the HasValidWebExperiencePack() method from the DashboardViewModel to the more appropriate WidgetHostingService.
  • Simplifies Commands in the DashboardView. Since both objects with Commands are Buttons, we can place the command directly on the button.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau force-pushed the krschau/win10-moveWebExpCheck branch from 02c9e92 to 76e2a7e Compare December 12, 2023 19:12
@krschau krschau mentioned this pull request Dec 12, 2023
3 tasks
@krschau krschau merged commit 2dbec2c into feature/win10 Dec 13, 2023
EricJohnson327 added a commit that referenced this pull request Jan 5, 2024
* Enable down level support

* Update to 22H2

* Include widget service info in bug reports

* update how we compare version numbers

* Move HasValidWebExperiencePack from DashboardViewModel to WidgetHostingService (#2042)

* Install Windows 10 widget service (#2044)

* Change TargetDeviceFamily MinVersion (#2100)

---------

Co-authored-by: Eric Johnson <ericjohnson327@gmail.com>
@krschau krschau deleted the krschau/win10-moveWebExpCheck branch January 25, 2024 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants