parse HTTP headers without asking for them again #1837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slawomir2
force-pushed
the
fix_headers_parsing
branch
from
655f153 to
0b1ce31
Compare
Author
|
Code removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1212
The old code was calling WinHttpQueryHeaders 2nd time but that was sometimes resulting in headers not being found in case the request_handle was reset in the meantime
WinHttpQueryHeaders would then return false and GetLastError() would return ERROR_INVALID_HANDLE.
Eventually application would crash due to uncaught exception thrown by stoi() function when it was passed an empty string (exit code 0xc0000409 which does not necessarily mean stack overflow