.NET: Fix sample resource path resolution#3952
Open
westey-m wants to merge 1 commit intomicrosoft:mainfrom
Open
.NET: Fix sample resource path resolution#3952westey-m wants to merge 1 commit intomicrosoft:mainfrom
westey-m wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates .NET GettingStarted workflow samples to load text resources relative to the executable output directory (instead of the current working directory), fixing failures when running via dotnet run.
Changes:
- Switch resource file loading from a relative path (
Resources/...) toPath.Combine(AppContext.BaseDirectory, "Resources", ...)across affected samples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/samples/GettingStarted/Workflows/SharedStates/Resources.cs | Reads resources from the app base directory to work under dotnet run. |
| dotnet/samples/GettingStarted/Workflows/ConditionalEdges/01_EdgeCondition/Resources.cs | Same base-directory resource resolution change for this sample. |
| dotnet/samples/GettingStarted/Workflows/ConditionalEdges/02_SwitchCase/Resources.cs | Same base-directory resource resolution change for this sample. |
| dotnet/samples/GettingStarted/Workflows/ConditionalEdges/03_MultiSelection/Resources.cs | Same base-directory resource resolution change for this sample. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The samples were working when run from Visual Studio, but failing when using
dotnet rundue to the difference in the path from which they were executed.Description
Contribution Checklist