Fix RadioButton keyboard navigation in ItemsRepeater layout options #1998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue where the "Uniform grid" and "Custom virtualizing layout" radio buttons in the ItemsRepeater sample page had incorrect keyboard navigation behavior.
Problem
The radio buttons were implemented as individual
RadioButtonelements withClickhandlers, which caused both Tab and Arrow key navigation to work within the same group. This violated accessibility guidelines and confused keyboard users who expected:Solution
Replaced the individual
RadioButtonelements with aRadioButtonscontrol:Before:
After:
Updated the corresponding C# event handler to use
SelectionChangedEventArgsand get the selected item from theRadioButtonscontrol while maintaining all existing layout switching functionality.Benefits
Fixes #1943.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
e7bvsblobprodcus348.vsblob.vsassets.iodotnet restore WinUIGallery.sln(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.