-
Notifications
You must be signed in to change notification settings - Fork 711
Add warning for Fluent-only icons not available on Windows 10 #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
niels9001
merged 7 commits into
microsoft:main
from
Zakariathr22:feature/icon-warning-win10
Jul 21, 2025
Merged
Add warning for Fluent-only icons not available on Windows 10 #1925
niels9001
merged 7 commits into
microsoft:main
from
Zakariathr22:feature/icon-warning-win10
Jul 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
niels9001
requested changes
Jul 20, 2025
Collaborator
|
Amazing work as always! Added a few suggestions Would love to get @dotMorten 's feedback too |
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Niels Laute <niels.laute@live.nl>
…iathr22/WinUI-Gallery into feature/icon-warning-win10
niels9001
approved these changes
Jul 21, 2025
Collaborator
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a warning to indicate that some icons may not be available by default on Windows 10, especially those only included in the Segoe Fluent Icons set used by Windows 11. Main changes are:
IsSegoeFluentOnlyproperty to both theIconDataSchemaandIconDataclass.Motivation and Context
How Has This Been Tested?
Tested by manually setting the font to Segoe MDL2 Assets to simulate the default icon set on Windows 10 and verifying which icons fail to appear.
Screenshots (if appropriate):
Types of changes