-
Notifications
You must be signed in to change notification settings - Fork 711
Add ContentIsland page with Helmet demo (requires WinAppSDK 1.7 APIs) #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeffstall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just check into the experimental branch now, and then merge that branch into main once WASDK 1.7.0 is GA?
Hi, there's no dedicated experimental branch for this repo (WinUI-Gallery). I've heard there's a new plan for WindowsAppSDK-Samples where we'll check in code that uses experimental APIs to main, and then conditionally compile that code. Maybe we can do something similar here. |
For that, we essentially only need to check for WinUI 1.7 in the csproj and .cs file right? |
Well, the problem as I understand it is that:
I'm assuming we'll want to build Gallery with preview1 at some point, and if we did this would break. Maybe we could query the MicrosoftWindowsAppSDKChannel MSBuild property, and only use these APIs when it's set to "experimental" or "stable" (and not preview), but that seems like it's getting kinda fiddly. Adding @karkarl as well for more input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a final check when 1.7 stable is available and then we can get this in!
Zakariathr22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to include this in a ControlExample with code samples, as it was done in all the other samples?
Co-authored-by: Zakaria Tahri <101801384+Zakariathr22@users.noreply.github.com>
|
/azp run |
1 similar comment
|
/azp run |


Description
Adds a ContentIsland page that uses Scene Node APIs to show a 3D model of a helmet.
Motivation and Context
This shows how apps can use ChildSiteLink to attach a ContentIsland in a Xaml app.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes