Skip to content

Fix settings page crash on Windows 10 #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scottj1s merged 4 commits into from
Apr 25, 2024
Merged

Fix settings page crash on Windows 10 #1480

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
718d290
Empty commit trigger build
HO-COOH Jan 18, 2024
b2b4071
Fix: Settings crash
HO-COOH Mar 7, 2024
1eae11a
Empty commit trigger build
HO-COOH Jan 18, 2024
6e20bf4
Merge branch 'main' into fix/settings-crash
HO-COOH Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions WinUIGallery/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,19 @@ public static string WinAppSdkRuntimeDetails
{
get
{
// Retrieve Windows App Runtime version info dynamically
var windowsAppRuntimeVersion =
from module in Process.GetCurrentProcess().Modules.OfType<ProcessModule>()
where module.FileName.EndsWith("Microsoft.WindowsAppRuntime.Insights.Resource.dll")
select FileVersionInfo.GetVersionInfo(module.FileName);
return WinAppSdkDetails + ", Windows App Runtime " + windowsAppRuntimeVersion.First().FileVersion;
try
{
// Retrieve Windows App Runtime version info dynamically
var windowsAppRuntimeVersion =
from module in Process.GetCurrentProcess().Modules.OfType<ProcessModule>()
where module.FileName.EndsWith("Microsoft.WindowsAppRuntime.Insights.Resource.dll")
select FileVersionInfo.GetVersionInfo(module.FileName);
return WinAppSdkDetails + ", Windows App Runtime " + windowsAppRuntimeVersion.First().FileVersion;
}
catch
{
return WinAppSdkDetails + $", Windows App Runtime {WASDK.Runtime.Version.Major}.{WASDK.Runtime.Version.Minor}";
}
}
}

Expand Down