Incremental Fixes to Refactor Codebase #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
reviewed
Feb 15, 2024
Comment on lines
+45
to
+46
| <x:String x:Key="ControlsName">All samples</x:String> | ||
| <x:String x:Key="AppTitleName">WinUI 3 Gallery</x:String> |
Contributor
There was a problem hiding this comment.
With regard to how localized apps would do this, we would not define this in XAML but rather add the resource to the Resources.resw file instead. To be fair, we don't do it elsewhere but wanted to mention it given folks use this app for guidance and to learn about WinUI.
Contributor
There was a problem hiding this comment.
Albeit you just moved it so maybe this is something for another time
Collaborator
Author
|
/azp run |
marcelwgn
approved these changes
Feb 16, 2024
karkarl
added a commit
that referenced
this pull request
Jul 15, 2024
## Description First attempt to clean up the codebase: - Clean up themeresources and styles in App.xaml - Fix minimal mode TitleBar layout - CaptureElement and AnnotatedScrollBar Icons ## Motivation and Context Part of #1279 efforts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First attempt to clean up the codebase:
Motivation and Context
Part of #1279 efforts