Remove useless api check in the animation interop page code sample #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
approved these changes
Dec 19, 2023
Contributor
marcelwgn
left a comment
marcelwgn
left a comment
There was a problem hiding this comment.
Good catch, thank you for fixing this!
Collaborator
|
@HO-COOH I guess we need an empty commit here as well (as part of: #1423 (comment)) |
Contributor
Author
Done |
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
…1418) <!--- Provide a general summary of your changes in the Title above --> ## Description Remove api check in code sample of winui3 animation interop page ## Motivation and Context Because it's unnecessary. WinUI3 has decoupled compositor ## How Has This Been Tested? Manual ## Screenshots (if appropriate): ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove api check in code sample of winui3 animation interop page
Motivation and Context
Because it's unnecessary. WinUI3 has decoupled compositor
How Has This Been Tested?
Manual
Screenshots (if appropriate):
Types of changes