Minor fix for releasing new version #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vyokky
commented
May 6, 2024
vyokky
commented
- Update readme.md
- Merge visual and non-visual prompt into a single file
- Auto-registering new api/Command via api.yaml configuration.
kangyu
reviewed
May 8, 2024
| } | ||
|
|
||
| api_prompt = APIPromptLoader("").load_ui_api_prompt() | ||
| class_name_dict = self.filter_api_dict(api_prompt, "class_name") |
Collaborator
There was a problem hiding this comment.
This function involves a constant value "class_name" as parameter. The value is in the prompt file. If we modify the prompt file, it is easy to forget modifying many places that call this function. Better put this function and constant to APIPromptLoader class.
kangyu
reviewed
May 8, 2024
| :return: The prompt template for UI APIs. | ||
| """ | ||
|
|
||
| config_key = "API_PROMPT" |
Collaborator
There was a problem hiding this comment.
Should we better put such config constant in configs class? Otherwise, may loss track if we change some key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.