et_text enabled #35
Merged
et_text enabled #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyokky
reviewed
Mar 24, 2024
ufo/ui_control/executor.py
Outdated
| args = {"text": args_dict["text"]} | ||
| else: | ||
| args = {"text": args_dict["text"]} | ||
| raise ValueError(f"INPUT_TEXT_API {configs['INPUT_TEXT_API']} not supported") |
Contributor
There was a problem hiding this comment.
If config not correct, it should use a default method name. Choose one that is more general
ufo/ui_control/executor.py
Outdated
| result = self.atomic_execution(self.control, method_name, args) | ||
| else: | ||
| result = self.set_text(method_name, args) | ||
| if configs["INPUT_TEXT_ENTER"] and method_name in ["type_keys", "set_edit_text", "set_text"]: |
Contributor
There was a problem hiding this comment.
Is set_edit_text still take effect in the list?
ufo/ui_control/executor.py
Outdated
| if args["text"] not in self.control.window_text(): | ||
| raise Exception(f"Failed to use set_text: {args['text']}") | ||
| return result | ||
| except: |
Contributor
There was a problem hiding this comment.
Is it possible to merge two func into one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.