Implementation of execution_flow #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyokky
reviewed
Nov 25, 2024
.gitignore
Outdated
| .vscode | ||
|
|
||
| # Ignore the logs | ||
| logs 3/* |
instantiation/config/config_dev.yaml
Outdated
| FILTER_PROMPT: "instantiation/controller/prompts/{mode}/filter.yaml" # The prompt for the filter | ||
| PREFILL_EXAMPLE_PROMPT: "instantiation/controller/prompts/{mode}/prefill_example.yaml" # The prompt for the action prefill example | ||
| EXECUTE_PROMPT: "instantiation/controller/prompts/{mode}/execute.yaml" # The prompt for the action execute | ||
| EXECUTE_PROMPT: "instantiation/controller/prompts/{mode}/execute.yaml" # The prompt for the action execute |
instantiation/config/config_dev.yaml
Outdated
| RECTANGLE_TIME: 1 | ||
| SHOW_VISUAL_OUTLINE_ON_SCREEN: False | ||
| INCLUDE_LAST_SCREENSHOT: False # Whether to include the last screenshot in the observation | ||
| CONCAT_SCREENSHOT: False # Whether to concat the screenshot for the control item |
Contributor
There was a problem hiding this comment.
read default config from ufo
| self._status = None | ||
| self._process_name = process_name | ||
| self._app_root_name = app_root_name | ||
| self._memory = Memory() |
| self.app_root_name, self.app_name | ||
| ) | ||
| self._control_inspector = ControlInspectorFacade(_BACKEND) | ||
| self._control_inspector = ControlInspectorFacade(_BACKEND) |
| super().__init__(agent=ExecuteAgent, context=context) | ||
|
|
||
| self.execution_time = 0 | ||
| self._app_env = environment |
| # self._response_json = self.app_agent.response_to_dict(self._response) | ||
|
|
||
| # except Exception: | ||
| # self.general_error_handler() |
| """ | ||
|
|
||
| control_selected = self._annotation_dict.get(self._control_label, None) | ||
| control_selected_2 = self._annotation_dict.get(self.control_text, None) |
| "Results": self._results, | ||
| } | ||
| self._memory_data.set_values_from_dict(self._response_json) | ||
| self._memory_data.set_values_from_dict(self._response) |
| Save the screenshot to the blackboard if the SaveScreenshot flag is set to True by the AppAgent. | ||
| """ | ||
| screenshot_saving = self._response_json.get("SaveScreenshot", {}) | ||
| screenshot_saving = self._response.get("SaveScreenshot", {}) |
vyokky
reviewed
Dec 5, 2024
| ```bash | ||
| python -m dataflow single execution /task_dir/task_file_name | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Add args for other parameters
| python -m dataflow batch dataflow /path/to/task_dir/ | ||
| ``` | ||
| * Instantiation Task Batch: | ||
| ```bash |
Contributor
There was a problem hiding this comment.
No need to specify folder and file
dataflow/config/config_dev.yaml
Outdated
| AOAI_DEPLOYMENT: "gpt-4-visual-preview" # Your AOAI deployment if apply | ||
| API_VERSION: "2024-02-15-preview" # "2024-02-15-preview" by default. | ||
| OPENAI_API_MODEL: "gpt-4-0125-preview" # The only OpenAI model by now that accepts visual input | ||
|
|
Contributor
There was a problem hiding this comment.
double check, split the config to this module
Contributor
There was a problem hiding this comment.
The config will not work for Openai and aoai
dataflow/data_flow_controller.py
Outdated
| } | ||
| return init_task_info | ||
|
|
||
| def _load_schema(self, task_type: str) -> dict: |
Contributor
There was a problem hiding this comment.
from typing import Dict, List, Tuple
Dict[str, str]
dataflow/data_flow_controller.py
Outdated
| ) | ||
| return prefill_result["instantiated_plan"] | ||
|
|
||
| def execute_execution(self, request: str, plan: dict) -> None: |
| # Dataflow | ||
|
|
||
| Dataflow uses UFO to implement `instantiation`, `execution`, and `dataflow` for a given task, with options for batch processing and single processing. | ||
|
|
vyokky
reviewed
Dec 8, 2024
dataflow/config/config_dev.yaml
Outdated
| AOAI_DEPLOYMENT: "gpt-4-visual-preview" # Your AOAI deployment if apply | ||
| API_VERSION: "2024-02-15-preview" # "2024-02-15-preview" by default. | ||
| OPENAI_API_MODEL: "gpt-4-0125-preview" # The only OpenAI model by now that accepts visual input | ||
|
|
Contributor
There was a problem hiding this comment.
The config will not work for Openai and aoai
ufo/agents/agent/app_agent.py
Outdated
| ) -> None: | ||
| """ | ||
| Initialize the AppAgent. | ||
| Initialize the AppAgent.TODO:simplify related init |
Contributor
There was a problem hiding this comment.
Please do not change code in UFO, also do not add redundant comment.
| """ | ||
|
|
||
| control_selected = self._annotation_dict.get(self._control_label, None) | ||
| control_selected = self._annotation_dict.get(self._control_label, "") |
Contributor
There was a problem hiding this comment.
Do not change. The logic is wrong.
vyokky
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.