-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<functional>: unwrap move_only_function with abominable and noexcept types
#5917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexGuteniev
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
AlexGuteniev:abominable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d76684 to
362c4f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5504.
Follow up on #5808.
📦 Newly unwrapped cases
move_only_function<R(Args...) cv1-ref1-noex1>(move_only_function<R(Args...) cv2-ref2-noex2>(callable));wherenoexceptandconstmay be present in only inner, and&or&&may be present in only outermove_only_function<R(Args...) cv-ref>(function<R(Args...)>(callable))where cv-ref can haveconst,&, and&&.In the tests make sure the type system is not broken, and the cases which are not supposed to compile, still do not compile.
🐿️ Squirrelly case
Inner
noexcept, outer non-noexceptcase is squirrelly.If we keep conditional
noexcepton the structure, it would violate strict aliasing: the inner one would have a different_Function_baseand thus_Function_base::_Impl_t.Alternatives:
_Noexceptparameter from_Function_base, and pass that as template parameter on function construction, also dress it onto_Invokepointer withreinterpret_castwhen needed. This is doable, but makes the current change more complicated.noexceptvarying case unwrapped.noexceptfunction pointer (bad, missed optimization we're asked to do)._Impl_t(need to get that working in clang-cl somehow, as it can't assign function pointer tovoid*)