Skip to content

Conversation

@trlemon
Copy link
Contributor

@trlemon trlemon commented Oct 30, 2025

Summary of Changes

  1. Added missing commands to lakeshore_model335.yaml, lakeshore_model336.yaml, lakeshore_model372.yaml and rename some properties for clarity.
  2. Added logic to lakeshore_base.py to bypass "blocking" functionality in blocking_t while in simulated mode.
  3. Updated tests for Lakeshore Models 325, 335, 336, and 372 to use pyvisa-sim backend instead of mocked classes.

@trlemon trlemon changed the title Tlemon/fix lakeshore pyvisa sim yaml Update LakeshoreModel336 pyvisa-sim YAML Oct 30, 2025
@trlemon trlemon changed the title Update LakeshoreModel336 pyvisa-sim YAML Update LakeshoreModel3xx pyvisa-sim YAMLs and tests Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.77%. Comparing base (17c144e) to head (f05643b).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7606   +/-   ##
=======================================
  Coverage   59.77%   59.77%           
=======================================
  Files         351      351           
  Lines       31653    31654    +1     
=======================================
+ Hits        18920    18921    +1     
  Misses      12733    12733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@picarro-yren picarro-yren marked this pull request as ready for review November 4, 2025 17:27
@picarro-yren picarro-yren requested a review from a team as a code owner November 4, 2025 17:27
@picarro-yren picarro-yren added this pull request to the merge queue Nov 6, 2025
Merged via the queue into microsoft:main with commit 470fb84 Nov 6, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants