Skip to content

Conversation

@jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 30, 2025

InstrumentLoggerAdapter by default discards any information that is added to the LogRecord via extra. This extends the new 3.13 feature to allow the user to add extra information to the messages logged via the InstrumentLoggerAdapter regardless of the version of python.

@jenshnielsen jenshnielsen force-pushed the log_extra branch 3 times, most recently from 0440f02 to 1346920 Compare May 30, 2025 11:40
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.92%. Comparing base (e7eaf4d) to head (5aa5f8e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/logger/instrument_logger.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7186   +/-   ##
=======================================
  Coverage   59.92%   59.92%           
=======================================
  Files         342      342           
  Lines       31472    31481    +9     
=======================================
+ Hits        18859    18865    +6     
- Misses      12613    12616    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This allows the user to add extra information to the messages
logged via the InstrumentLoggerAdapter.
@jenshnielsen jenshnielsen changed the title [wip] Allow extra on log messages via InstrumentLogger Allow extra on log messages via InstrumentLogger May 30, 2025
@jenshnielsen jenshnielsen marked this pull request as ready for review May 30, 2025 12:17
@jenshnielsen jenshnielsen requested a review from a team as a code owner May 30, 2025 12:17
@jenshnielsen jenshnielsen added this pull request to the merge queue Jun 2, 2025
Merged via the queue into microsoft:main with commit d3135df Jun 2, 2025
16 checks passed
@jenshnielsen jenshnielsen deleted the log_extra branch June 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants