This repository was archived by the owner on Mar 21, 2024. It is now read-only.
BUG: Dont update multi-node env vars for single node training#796
Merged
BUG: Dont update multi-node env vars for single node training#796
Conversation
mebristo
changed the title
Contributor
|
@mebristo, can we not use the updated function from hi-ml? Just publish a new package version and consume it here. |
Contributor
Author
|
I sent you a message about this offline - the hi-ml package hasn't been updated in a while, so updating it in this PR would also require refactoring how users can provide conda files (since merge_conda_files has been removed from hi-ml in favour of a single command line arg) ... so in the spirit of a 'quick fix' to unblock PRs I felt this was the best approach |
mebristo
changed the title
ant0nsc
approved these changes
Sep 2, 2022
fepegar
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environemnt variables seem to be getting set in Azure ML for single node jobs that cause our logic to fail in
set_environment_variables_for_multi_nodetherefore we should avoid calling this for jobs on 1 node