This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Enabling distributed training for SSL online evaluator#612
Merged
Conversation
ozan-oktay
previously approved these changes
Dec 9, 2021
ozan-oktay
approved these changes
Dec 9, 2021
Shruthi42
reviewed
Dec 10, 2021
| trainer2.fit(model, datamodule=data) | ||
| # Read the parameters and check if they are the same as what was stored in the first callback. | ||
| parameters2_after_training = list(callback2.evaluator.parameters()) | ||
| assert torch.allclose(parameters2_after_training[0], parameters1[0]) |
Contributor
There was a problem hiding this comment.
Could we also check if the optimizer state is restored correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL online evaluator presently is not synchronizing across GPUs. Enable DDP.
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.