improvement(client-core-interfaces): remove unused impls#26952
Open
jason-ha wants to merge 3 commits intomicrosoft:mainfrom
Open
improvement(client-core-interfaces): remove unused impls#26952jason-ha wants to merge 3 commits intomicrosoft:mainfrom
jason-ha wants to merge 3 commits intomicrosoft:mainfrom
Conversation
`ErasedType` and `ErasedBaseType` are never to be instantiated nor checked for instanceof. Thus don't need implementations. Remove those implementations.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make ErasedType / ErasedBaseType purely compile-time brands by removing their runtime implementations.
Changes:
- Converted
ErasedTypeandErasedBaseTypefrom emitted classes todeclareclasses. - Replaced the runtime
Symbol.hasInstancethrow inErasedTypewith a declaration-only signature. - Removed constructor bodies (converted to signature-only) to keep the types unconstructable.
| * | ||
| * This class should only be a `type` package export, preventing users from extending it directly. | ||
| * But since {@link ErasedTypeImplementation} does extend it an implementation | ||
| * for ctor must be provided, unlike {@link ErasedType}. |
Contributor
There was a problem hiding this comment.
Suggested change
| * for ctor must be provided, unlike {@link ErasedType}. | |
| * for `constructor` must be provided, unlike {@link ErasedType}. |
See https://github.com/microsoft/FluidFramework/wiki/Coding-Guidelines#-avoid-using-abbreviations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErasedTypeis never to be instantiated nor checked forinstanceof. Thus, don't need implementations. Remove those implementations.