Skip to content

fix: tree agent rendering of fluid handles#26292

Merged
jenn-le merged 5 commits intomicrosoft:mainfrom
jenn-le:tree-agent-handle-schema
Jan 28, 2026
Merged

fix: tree agent rendering of fluid handles#26292
jenn-le merged 5 commits intomicrosoft:mainfrom
jenn-le:tree-agent-handle-schema

Conversation

@jenn-le
Copy link
Copy Markdown
Contributor

@jenn-le jenn-le commented Jan 27, 2026

This fixes a bug where tree agent does not render fluid handles.

@jenn-le jenn-le marked this pull request as ready for review January 27, 2026 17:49
Copilot AI review requested due to automatic review settings January 27, 2026 17:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the tree agent does not render fluid handles properly in TypeScript type generation.

Changes:

  • Added support for rendering ValueSchema.FluidHandle as IFluidHandle type in TypeScript output
  • Added conditional generation of the IFluidHandle type definition only when handles are present in the schema
  • Added test coverage for handle node rendering

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/framework/tree-agent/src/renderSchemaTypeScript.ts Implements fluid handle rendering by adding a flag tracker, updating the renderLeaf function to handle FluidHandle case, and conditionally including the IFluidHandle type definition
packages/framework/tree-agent/src/test/typeGeneration.spec.ts Adds a test case that verifies fluid handles are correctly rendered as IFluidHandle type with appropriate documentation

@jenn-le jenn-le enabled auto-merge (squash) January 27, 2026 23:25
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  252163 links
    1804 destination URLs
    2045 URLs ignored
       0 warnings
       0 errors


@jenn-le jenn-le merged commit cc6518a into microsoft:main Jan 28, 2026
32 checks passed
jenn-le added a commit to jenn-le/FluidFramework that referenced this pull request Jan 28, 2026
This fixes a bug where tree agent does not render fluid handles.
jenn-le added a commit that referenced this pull request Jan 28, 2026
This fixes a bug where tree agent does not render fluid handles.

Cherry picked from:
#26292
@daesunp daesunp mentioned this pull request Jan 28, 2026
daesunp added a commit that referenced this pull request Jan 28, 2026
## Description

bump 2.81.1 to 2.81.2

link to main PR
#26292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants