fix: tree agent rendering of fluid handles#26292
Merged
jenn-le merged 5 commits intomicrosoft:mainfrom Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the tree agent does not render fluid handles properly in TypeScript type generation.
Changes:
- Added support for rendering
ValueSchema.FluidHandleasIFluidHandletype in TypeScript output - Added conditional generation of the
IFluidHandletype definition only when handles are present in the schema - Added test coverage for handle node rendering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/framework/tree-agent/src/renderSchemaTypeScript.ts | Implements fluid handle rendering by adding a flag tracker, updating the renderLeaf function to handle FluidHandle case, and conditionally including the IFluidHandle type definition |
| packages/framework/tree-agent/src/test/typeGeneration.spec.ts | Adds a test case that verifies fluid handles are correctly rendered as IFluidHandle type with appropriate documentation |
noencke
reviewed
Jan 27, 2026
noencke
reviewed
Jan 27, 2026
noencke
reviewed
Jan 27, 2026
noencke
approved these changes
Jan 28, 2026
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
jenn-le
added a commit
to jenn-le/FluidFramework
that referenced
this pull request
Jan 28, 2026
This fixes a bug where tree agent does not render fluid handles.
jenn-le
added a commit
that referenced
this pull request
Jan 28, 2026
Merged
daesunp
added a commit
that referenced
this pull request
Jan 28, 2026
## Description bump 2.81.1 to 2.81.2 link to main PR #26292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where tree agent does not render fluid handles.