fix(server): LocalOrdererManager removeOrderer to no-op#24442
Merged
znewton merged 1 commit intomicrosoft:mainfrom Apr 24, 2025
Merged
fix(server): LocalOrdererManager removeOrderer to no-op#24442znewton merged 1 commit intomicrosoft:mainfrom
znewton merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses AB#35445 by updating the LocalOrdererManager's removeOrderer function to become a no-op, ensuring that orderer connections in the local environment are not inadvertently disconnected.
- Removed the deletion of local orderer connections and the associated call to close the connection.
- Added a clarifying comment that explains local orderer connections are managed separately.
github-actions
bot
added
area: server
jikim-msft
approved these changes
Apr 23, 2025
markfields
pushed a commit
to markfields/FluidFramework
that referenced
this pull request
Apr 24, 2025
) ## Description Fixes [AB#35445](https://dev.azure.com/fluidframework/internal/_workitems/edit/35445). LocalOrdererManager handles connection cleanup differently from Nexus' OrdererManager. microsoft#21528 incorrectly caused disconnect socket connection to sever all current orderer connections. <details> <summary>Note on memory use</summary> I had a much longer PR in progress to share logic between the Nexus OrdererManager and LocalOrdererManager, but it got way too complicated, and really the number of connections held by T9s shouldn't apply memory pressure like it would in Nexus </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AB#35445.
LocalOrdererManager handles connection cleanup differently from Nexus' OrdererManager. #21528 incorrectly caused disconnect socket connection to sever all current orderer connections.
Note on memory use
I had a much longer PR in progress to share logic between the Nexus OrdererManager and LocalOrdererManager, but it got way too complicated, and really the number of connections held by T9s shouldn't apply memory pressure like it would in Nexus