-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for client authentication #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spaceisfun
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
spaceisfun:bidirectionalcert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp where |
|
Azure DevOps orgs getting events for this repository: |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Factory Orchestrator Service to optionally require clients provide an SSL Certificate before the Service allows the client to connect. If a certificate is not provided or does not match the allowed certificates, the client will not be able to interact with the Service at all. This is not enforced for localhost/loopback connections.
The certificate can be provided in the FactoryOrchestratorClient ctor() or as a property.
This change required IPC framework changes that are not yet in jkang.ipcserviceframwork. I will attempt to port them into the official git repo when time permits.
Verified this works on desktop, FactoryOS, linux & pwsh
Note to review the PR, i suggest using the filters by file type or commit or you will see a ton of autogenerated doc file changes

Docs can be previewed at https://spaceisfun.github.io/FactoryOrchestrator/