Skip to content

Conversation

@spaceisfun
Copy link
Member

@spaceisfun spaceisfun commented Dec 31, 2022

This PR updates the Factory Orchestrator Service to optionally require clients provide an SSL Certificate before the Service allows the client to connect. If a certificate is not provided or does not match the allowed certificates, the client will not be able to interact with the Service at all. This is not enforced for localhost/loopback connections.

The certificate can be provided in the FactoryOrchestratorClient ctor() or as a property.

This change required IPC framework changes that are not yet in jkang.ipcserviceframwork. I will attempt to port them into the official git repo when time permits.

  • Dns-SD information now contains service certificate hash and identity as those are not really 'secrets' they should be used by the client to determine if a service is trustworthy. Clients are auto-populated with these set when possible.
  • Updated docs to reflect the new options & for better clarity
  • All autogenerated .md/doc filenames are changed due to DefaultDocumentation update
  • This is a breaking change so major version is incremented.

Verified this works on desktop, FactoryOS, linux & pwsh

Note to review the PR, i suggest using the filters by file type or commit or you will see a ton of autogenerated doc file changes
image

Docs can be previewed at https://spaceisfun.github.io/FactoryOrchestrator/

@spaceisfun spaceisfun added the enhancement New feature or request label Dec 31, 2022
@spaceisfun
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@spaceisfun spaceisfun self-assigned this Dec 31, 2022
@spaceisfun
Copy link
Member Author

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@spaceisfun
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@spaceisfun
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant