This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Removing last tile from data string when remove action is invoked#77
Merged
guimafelipe merged 1 commit intomainfrom Dec 13, 2023
Merged
Removing last tile from data string when remove action is invoked#77guimafelipe merged 1 commit intomainfrom
guimafelipe merged 1 commit intomainfrom
Conversation
dkbennett
approved these changes
Dec 12, 2023
EricJohnson327
approved these changes
Dec 12, 2023
krschau
approved these changes
Dec 13, 2023
bbonaby
pushed a commit
that referenced
this pull request
Feb 22, 2024
Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR fixes a bug in the Azure Query Tiles widget where the
ConfigurationDatastring was inconsistent with the actual state of the widget when the user clicks the remove tile button.References and relevant issues
#65
Detailed description of the pull request / Additional comments
Before
When the user clicks the "Remove tile" button, the data string the widget receives still contains information from the removed form. This resulted in a configuration being saved with a ghost tile if the remove action was the last one invoked before pinning or saving.
This resulted in the widget showing this ghost tile whenever it needed to reload all the tiles from the
ConfigurationDatastring, as this string is mirroring the data received from the forms. This happens when the widget service is restarted or when the user cancels a customization action.Currently
Now, invoking the remove widget action will remove the information from the last form from the data string accordingly, as this tile should not exist anymore. This way, the data will stay consistent with the intended behaviour of the widget, and will not have ghost tiles on the next restorations.
Validation steps performed
PR checklist