Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Comments

Removing last tile from data string when remove action is invoked#77

Merged
guimafelipe merged 1 commit intomainfrom
user/felipeda/resetbug
Dec 13, 2023
Merged

Removing last tile from data string when remove action is invoked#77
guimafelipe merged 1 commit intomainfrom
user/felipeda/resetbug

Conversation

@guimafelipe
Copy link
Contributor

Summary of the pull request

This PR fixes a bug in the Azure Query Tiles widget where the ConfigurationData string was inconsistent with the actual state of the widget when the user clicks the remove tile button.

References and relevant issues

#65

Detailed description of the pull request / Additional comments

Before

When the user clicks the "Remove tile" button, the data string the widget receives still contains information from the removed form. This resulted in a configuration being saved with a ghost tile if the remove action was the last one invoked before pinning or saving.

This resulted in the widget showing this ghost tile whenever it needed to reload all the tiles from the ConfigurationData string, as this string is mirroring the data received from the forms. This happens when the widget service is restarted or when the user cancels a customization action.

Currently

Now, invoking the remove widget action will remove the information from the last form from the data string accordingly, as this tile should not exist anymore. This way, the data will stay consistent with the intended behaviour of the widget, and will not have ghost tiles on the next restorations.

Validation steps performed

PR checklist

@dkbennett dkbennett added the Needs-Second Pull request that needs another approval label Dec 12, 2023
@guimafelipe guimafelipe merged commit f011c02 into main Dec 13, 2023
@krschau krschau removed the Needs-Second Pull request that needs another approval label Dec 14, 2023
bbonaby pushed a commit that referenced this pull request Feb 22, 2024
Co-authored-by: Felipe da Conceicao Guimaraes <felipeda@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query tile did not save changes made on Dashboard

4 participants