Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Comments

Add launch button, reduce wait, and better checking for status of Dev Boxes for config flow#195

Merged
huzaifa-d merged 5 commits intomainfrom
user/modanish/StatusRecheck
May 31, 2024
Merged

Add launch button, reduce wait, and better checking for status of Dev Boxes for config flow#195
huzaifa-d merged 5 commits intomainfrom
user/modanish/StatusRecheck

Conversation

@huzaifa-d
Copy link
Contributor

Summary of the pull request

  • Adds a launch button to directly login to a Dev Box in the case of "Waiting For Active User Session" while applying a configuration.
  • Reduces the wait time for a task to resume to complement the fix by the Dev Box team. It is now 30 seconds for normal logins but two minutes in the case of first time login initializations.
  • Rechecks the status of a Dev Box before applying a configuration. Earlier if a Dev Box was started in the background during the configuration flow setup, the extension wasn't aware and failed the configuration task.

image

Validation steps performed

Manually across multiple Dev Boxes

PR checklist

@huzaifa-d huzaifa-d requested review from bbonaby, dhoehna and sshilov7 May 23, 2024 21:04
var computeSystems = await GetDevBoxesAsync(developerId);

_log.Information($"Successfully retrieved all Dev Boxes for {developerId.LoginId}, at {DateTime.Now}");
_log.Information($"Successfully retrieved all Dev Boxes for {developerId.LoginId}, in {DateTime.Now - start}");
Copy link
Contributor

@dhoehna dhoehna May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the stopwatch class to keep track of how long the task took.

This method is prone to errors via DST.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a less error-prone method of getting elapsed time is to use UTCNow.


private ManualResetEvent _launchEvent;

private const string _waitingForUserSessionState = "WaitingForUserSession";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding guidelines: Normally constant names don't start with "_": "Use PascalCase for constant names, both fields and local constants."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev Box configuration waits a couple of minutes to show status Dev home does not refresh Dev Box Status after machine start

6 participants