This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
dhoehna
reviewed
May 28, 2024
src/AzureExtension/DevBox/Helpers/WaitingForUserAdaptiveCardSession.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
May 28, 2024
dhoehna
reviewed
May 28, 2024
src/AzureExtension/DevBox/Helpers/WaitingForUserAdaptiveCardSession.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
May 28, 2024
| var computeSystems = await GetDevBoxesAsync(developerId); | ||
|
|
||
| _log.Information($"Successfully retrieved all Dev Boxes for {developerId.LoginId}, at {DateTime.Now}"); | ||
| _log.Information($"Successfully retrieved all Dev Boxes for {developerId.LoginId}, in {DateTime.Now - start}"); |
Contributor
There was a problem hiding this comment.
Consider using the stopwatch class to keep track of how long the task took.
This method is prone to errors via DST.
Contributor
There was a problem hiding this comment.
I believe a less error-prone method of getting elapsed time is to use UTCNow.
src/AzureExtension/DevBox/Helpers/WaitingForUserAdaptiveCardSession.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
May 29, 2024
src/AzureExtension/DevBox/Helpers/WaitingForUserAdaptiveCardSession.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
May 31, 2024
|
|
||
| private ManualResetEvent _launchEvent; | ||
|
|
||
| private const string _waitingForUserSessionState = "WaitingForUserSession"; |
Member
There was a problem hiding this comment.
Coding guidelines: Normally constant names don't start with "_": "Use PascalCase for constant names, both fields and local constants."
sshilov7
approved these changes
May 31, 2024
kanismohammed
approved these changes
May 31, 2024
This was
linked to
issues
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Validation steps performed
Manually across multiple Dev Boxes
PR checklist