Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Update AzureUri for onprem support and handle VssResourceNotFound error#123

Merged
dkbennett merged 3 commits intomainfrom
user/dkbennett/onprem
Feb 22, 2024
Merged

Update AzureUri for onprem support and handle VssResourceNotFound error#123
dkbennett merged 3 commits intomainfrom
user/dkbennett/onprem

Conversation

@dkbennett
Copy link
Member

@dkbennett dkbennett commented Feb 20, 2024

Summary of the pull request

Updates AzureUri to handle the format for On-Premeses DevOps servers (aka "onprem").

Also adds a specific error handling message for VssResourceNotFound error, which is what happens if you call an API that the devops server does not support. This was found against a DevOps Express install, which does not appear to have full rest API functionality.

References and relevant issues

Closes #45

Detailed description of the pull request / Additional comments

  • Updated AzureUri to support onprem format URIs.
  • Updated some error handling to check for the VssResourceNotFound exception.
  • Added some error handling strings that were missing which were hit while working on this feature.
  • Better handling of the null case of connections, which I encountered when testing onprem.
  • Updated the Validation tests for AzureUri to validate on-prem style Uris.
  • Updated RepositoryProvider uri validation test to account for the now less-rigid valid formats.

Validation steps performed

  • Installed DevOps express, created on-prem server local to my machine and tested the code against URLs to my local devops server.
  • Verified new onprem validation tests pass and process as expected.
  • Verified repositoryprovider Uri testing passes as before.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@dkbennett dkbennett marked this pull request as ready for review February 21, 2024 18:57
<comment>Shown in Widget when first pinned while waiting for data to load.</comment>
</data>
<data name="ErrorMessage.InitializeVssConnectionFailure" xml:space="preserve">
<value>Failed creating the Vss Connection</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments for all these strings.

@dkbennett dkbennett merged commit c205ed5 into main Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Azure DevOps Server

3 participants