Build a shared and static library #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That seems to break the Windows build. I remember in the original CMake config we explicitly didn't attempt to build static archives for Windows, maybe we need a similar restriction still? |
Owner
Author
|
I tried disabling the static library on Windows, but it still failed. I'll try setting up a Windows development machine, and see if I can figure out how to fix the build. |
arr2036
force-pushed
the
master
branch
2 times, most recently
from
090e0fc to
a8d7805
Compare
mheily
force-pushed
the
issue135/unified_shared_static
branch
from
c690637 to
8b826c4
Compare
Relates to issue#135
mheily
force-pushed
the
issue135/unified_shared_static
branch
from
e24621f to
35849fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue#135