Skip to content

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Feb 26, 2023

  • Fixes bounding-box position updating when zooming/panning while constructing a new bounding-box.
  • Drawing boxes and freehand-shapes now follows mouse-pointer while zooming/panning instead of jumping to new position when zooming/panning is finished.

Fixes #52 .

@mfl28 mfl28 self-assigned this Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 85.99% // Head: 85.76% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (a98abb3) compared to base (c3ad38c).
Patch coverage: 82.22% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
- Coverage     85.99%   85.76%   -0.23%     
+ Complexity     1405     1404       -1     
============================================
  Files            92       92              
  Lines          5739     5740       +1     
  Branches        518      519       +1     
============================================
- Hits           4935     4923      -12     
- Misses          546      560      +14     
+ Partials        258      257       -1     
Impacted Files Coverage Δ
...mfl28/boundingboxeditor/controller/Controller.java 77.96% <0.00%> (-0.26%) ⬇️
...fl28/boundingboxeditor/ui/EditorImagePaneView.java 86.00% <82.05%> (-2.19%) ⬇️
...ub/mfl28/boundingboxeditor/ui/BoundingBoxView.java 67.83% <100.00%> (-1.21%) ⬇️
...28/boundingboxeditor/ui/BoundingShapeViewData.java 84.90% <0.00%> (-1.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.0% 86.0% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit b5d30dc into master Feb 26, 2023
@mfl28 mfl28 deleted the bugfix/fix-drawing-zooming-interaction branch February 26, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix drawing-zooming interaction

2 participants