Skip to content

Fix L1 EInk HWModel#7346

Merged
thebentern merged 1 commit intomasterfrom
fix-l1-eink
Jul 15, 2025
Merged

Fix L1 EInk HWModel#7346
thebentern merged 1 commit intomasterfrom
fix-l1-eink

Conversation

@thebentern
Copy link
Contributor

I think this is correct. We still need the L1 macro for some of the base level specific behavior but we need the specific HW_MODEL in architecture.h to be the correct one.
@Dylanliacc

@thebentern thebentern requested a review from Copilot July 15, 2025 02:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the L1 EInk variant is recognized by defining its macro in the build configuration and mapping it to the correct hardware model in the architecture header.

  • Introduces -D SEEED_WIO_TRACKER_L1_EINK in the platformio.ini for the L1 EInk variant
  • Adds a new #elif branch in architecture.h to map the macro to meshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
variants/seeed_wio_tracker_L1_eink/platformio.ini Add -D SEEED_WIO_TRACKER_L1_EINK to the build_flags list
src/platform/nrf52/architecture.h Map SEEED_WIO_TRACKER_L1_EINK to the correct HW_VENDOR enum
Comments suppressed due to low confidence (3)

src/platform/nrf52/architecture.h:94

  • [nitpick] Add a brief comment here to indicate that this block covers the new Seeed WIO Tracker L1 EInk variant, which will help future maintainers understand the grouping of hardware models.
#elif defined(SEEED_WIO_TRACKER_L1_EINK)

src/platform/nrf52/architecture.h:95

  • Consider adding or updating a unit test to assert that defining SEEED_WIO_TRACKER_L1_EINK correctly maps to meshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK, catching any regressions in model selection.
#define HW_VENDOR meshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK

variants/seeed_wio_tracker_L1_eink/platformio.ini:7

  • Align the indentation of this -D line with the other build_flags entries to ensure PlatformIO parses it correctly as part of the same list.
  -D SEEED_WIO_TRACKER_L1_EINK

@thebentern thebentern merged commit 39716ed into master Jul 15, 2025
17 of 21 checks passed
@thebentern thebentern deleted the fix-l1-eink branch July 15, 2025 02:14
oscgonfer pushed a commit to fablabbcn/smartcitizen-meshtastic that referenced this pull request Jul 21, 2025
oscgonfer pushed a commit to fablabbcn/smartcitizen-meshtastic that referenced this pull request Jul 22, 2025
oscgonfer pushed a commit to fablabbcn/smartcitizen-meshtastic that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants