Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the L1 EInk variant is recognized by defining its macro in the build configuration and mapping it to the correct hardware model in the architecture header.
- Introduces
-D SEEED_WIO_TRACKER_L1_EINKin the platformio.ini for the L1 EInk variant - Adds a new
#elifbranch inarchitecture.hto map the macro tomeshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| variants/seeed_wio_tracker_L1_eink/platformio.ini | Add -D SEEED_WIO_TRACKER_L1_EINK to the build_flags list |
| src/platform/nrf52/architecture.h | Map SEEED_WIO_TRACKER_L1_EINK to the correct HW_VENDOR enum |
Comments suppressed due to low confidence (3)
src/platform/nrf52/architecture.h:94
- [nitpick] Add a brief comment here to indicate that this block covers the new Seeed WIO Tracker L1 EInk variant, which will help future maintainers understand the grouping of hardware models.
#elif defined(SEEED_WIO_TRACKER_L1_EINK)
src/platform/nrf52/architecture.h:95
- Consider adding or updating a unit test to assert that defining
SEEED_WIO_TRACKER_L1_EINKcorrectly maps tomeshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK, catching any regressions in model selection.
#define HW_VENDOR meshtastic_HardwareModel_SEEED_WIO_TRACKER_L1_EINK
variants/seeed_wio_tracker_L1_eink/platformio.ini:7
- Align the indentation of this
-Dline with the otherbuild_flagsentries to ensure PlatformIO parses it correctly as part of the same list.
-D SEEED_WIO_TRACKER_L1_EINK
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 21, 2025
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is correct. We still need the L1 macro for some of the base level specific behavior but we need the specific HW_MODEL in architecture.h to be the correct one.
@Dylanliacc