perf: Optimize Stringify with sync.Pool and strconv #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement sync.Pool for bytes.Buffer reuse in Stringify. - Replace fmt.Fprintf with zero-allocation strconv calls for primitives. - Fix float32/float64 formatting precision. - Add security warning to NewClient regarding default client timeouts. - Include benchmark test file `strings_benchmark_test.go` to verify performance and correctness. - Include table-driven test `TestStringify_Primitives` in `strings_test.go` to verify all primitive type code paths.
merchantmoh-debug
deleted the
bolt-sentinel-client-improvement-10999790790030565127
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings_benchmark_test.goto verify performance and correctness.TestStringify_Primitivesinstrings_test.goto verify all primitive type code paths.