Inline internal::type_name<> templates. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without inline, this template and its specializations are instantiated in each object file. In this case, we cannot link multiple object files which use toml.h. To avoid this conflict, this CL inlines the template.
Owner
|
Oops. Thanks for the quick fix! |
mayah
added a commit
that referenced
this pull request
Feb 11, 2016
Inline internal::type_name<> templates.
Contributor
Author
|
It is difficult to make a test to verify this situation in a reliable way, but you can check it as follows.
|
Owner
|
I'll write a link test to prevent this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This template and its specializations can be instantiated in each object file.
In such a case, we cannot link multiple object files which use toml.h.
Without
inline, it depends on compilers and its optimization settings whether this templates are in-line expanded.To help compilers to expand it and to avoid link conflicts, this CL adds
inlineattributes to the template.