Skip to content

Conversation

@peria
Copy link
Contributor

@peria peria commented Feb 8, 2016

Make tinytoml library compilable with Visual C++ compiler 2015.
What I did in this PR are

  • Make some functions to replace with GNU extensions.
  • Put some preprocessor directives to replace compiler specific attributes.
  • Update CMakeLists.txt to handle compiler options correctly.
  • Disable tests with multi-byte characters. Visual C++ cannot handle UTF8 without BOM.

With this PR, tinytoml can be compiled in DOS prompt.

C:\tinytoml>mkdir out
C:\tinytoml>cd out
C:\tinytoml\out>cmake ..\src -G"Visual Studio 14 2015 Win64"
C:\tinytoml\out>cmake --build .

@peria
Copy link
Contributor Author

peria commented Feb 8, 2016

... and I confirmed this PR also could be built with clang+ninja on my Linux.

$ mkdir out && cd out
$ cmake ../src -GNinja
$ ninja
$ ninja test

@peria
Copy link
Contributor Author

peria commented Feb 9, 2016

@mayah PTL

@mayah
Copy link
Owner

mayah commented Feb 9, 2016

Looks OK. LGTM

mayah added a commit that referenced this pull request Feb 9, 2016
Make tinytoml compilable with Visual C++ compiler.
@mayah mayah merged commit dd9311f into mayah:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants