Skip to content

WIP: 🩹 Issue 74: fix deprecation warning#75

Closed
thomasmerz wants to merge 10 commits intomaxam2017:masterfrom
thomasmerz:upstream
Closed

WIP: 🩹 Issue 74: fix deprecation warning#75
thomasmerz wants to merge 10 commits intomaxam2017:masterfrom
thomasmerz:upstream

Conversation

@thomasmerz
Copy link
Copy Markdown
Contributor

@thomasmerz thomasmerz commented Dec 13, 2022

Node.js 12 actions are deprecated
For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Please update the following actions to use Node.js 16: actions/checkout@v2
Using version v3, latest or master: actions/checkout#689

This PR fixes issue #74

@thomasmerz thomasmerz force-pushed the upstream branch 2 times, most recently from 0f52ab5 to a3ed09e Compare December 13, 2022 18:22
@thomasmerz
Copy link
Copy Markdown
Contributor Author

thomasmerz commented Dec 13, 2022 •
edited
Loading

See before:
https://github.com/thomasmerz/productive-box/actions/runs/3688147662 ❌
https://github.com/thomasmerz/productive-box/actions/runs/3688153259 ❌
And after:
🚧

@thomasmerz thomasmerz changed the title 🩹 Issue 74: fix deprecation warning WIP: 🩹 Issue 74: fix deprecation warning Dec 13, 2022
@thomasmerz
🩹 Issue 74: fix deprecation warning:
3201c2b 
   Node.js 12 actions are deprecated.
   For more information see:
   https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

   Please update the following actions to use Node.js 16: actions/checkout@v2
   Using version v3, latest or master: actions/checkout#689

   Please update the following actions to use Node.js 16: maxam2017/productive-box@master
maxam2017
maxam2017 reviewed Dec 17, 2022
View reviewed changes
.github/workflows/build.yml
@@ -12,9 +12,9 @@ jobs:
matrix:
node_version: [14]
Copy link
Copy Markdown
Owner

@maxam2017 maxam2017 Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node_version: [14]
node_version: [16]

@maxam2017
Copy link
Copy Markdown
Owner

maxam2017 commented Dec 22, 2022

Those change has already been done by other PRs.
Thank you for your contribution and I hope you will consider submitting a new pull request in the future.

@maxam2017 maxam2017 closed this Dec 22, 2022
@thomasmerz
Copy link
Copy Markdown
Contributor Author

thomasmerz commented Dec 23, 2022

@maxam2017

Those change has already been done by other PRs. Thank you for your contribution and I hope you will consider submitting a new pull request in the future.

Great, it's totally ok for me, that you used my issue/PR as an impuls to fix it yourself 👍🏼

But you're still using and old version of peter-evans/repository-dispatch@v1 which still uses Node 12. Please update this to v2, too.

@thomasmerz
Copy link
Copy Markdown
Contributor Author

thomasmerz commented Dec 23, 2022 •
edited
Loading

And why are all my "Update gist" GH actions failing since you merged your PR? 🤔

Update:
Weird. I regenerated this GH_TOKEN and now everything is fine again… Sorry for the trouble… 🤷🏼‍♂️

@thomasmerz thomasmerz mentioned this pull request Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxam2017 maxam2017 maxam2017 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomasmerz @maxam2017