Add bridge.filter.users config option to configure filtering of direct chats
#892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
requested changes
Feb 9, 2023
Member
tulir
left a comment
tulir
left a comment
There was a problem hiding this comment.
The new field also needs to be added to the config upgrader in config.py, otherwise looks fine
Contributor
Author
|
Please test this before merging, I currently cannot test it on my machine due to me not having a development Synapse server (yet)... |
tulir
approved these changes
Feb 26, 2023
mautrix_telegram/config.py
Outdated
Comment on lines
200
to
203
| if "bridge.filter.users" not in self: | ||
| base["bridge.filter.users"] = True | ||
| else: | ||
| copy("bridge.filter.users") |
Member
There was a problem hiding this comment.
Missing fields are already handled by copy
Suggested change
| if "bridge.filter.users" not in self: | |
| base["bridge.filter.users"] = True | |
| else: | |
| copy("bridge.filter.users") | |
| copy("bridge.filter.users") |
Contributor
Author
There was a problem hiding this comment.
Does it provide the correct default, though...?
Or does it just set it to None?
Co-authored-by: Tulir Asokan <tulir@maunium.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge.filter.usersis "null", direct chats will follow the previous settings.bridge.filter.usersis "true", direct chats will always be bridged.bridge.filter.usersis "false", direct chats will never be bridged.Marked as draft as I did not test it locally.
Fixes #665.