Better regex delimiter when matching URIs#2
Open
tabacco wants to merge 1 commit intomattoperry:masterfrom
tabacco:better-regex-delimiter
Open
Better regex delimiter when matching URIs#2tabacco wants to merge 1 commit intomattoperry:masterfrom tabacco:better-regex-delimiter
tabacco wants to merge 1 commit intomattoperry:masterfrom
tabacco:better-regex-delimiter
Conversation
…dn't occur in the config patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I altered the preg_match pattern to use '#' as the regex delimiter rather than '/' since slashes will appear in the config all the time, and # won't. This way it's not necessary to escape every slash in the config.
That said, it introduces a soft-breaking change to existing configs with escaped slashes, since '/' will now match literally.