Open
Conversation
the write was failing because of a 0 byte write attempt, the response was -1 vs 0 this results in not using the sdcard backend for storage for all boots after the initial
If the user arms the vehicle during the logging-persist-timeout we should rotate the log immediately.
mavlink log reads fail randomly, and you end up with a very large number of log files as we keep closing logs off and then discovering we should be logging
this prevents loss of log data when listing logs on file backend
zalice
requested review from
adriennet823,
rabad-matternet,
robkarol and
viet-nguyen-matternet
bhiln
approved these changes
Jun 7, 2022
adriennet823
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging hotfixes backported from ardupilot main stream.