Preserve media creation and modification time when building "camm" video#809
Open
Preserve media creation and modification time when building "camm" video#809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When building a CAMM (Camera Motion Metadata) track and injecting it into an MP4 video, the
creation_timeandmodification_timefields from the source video'smvhd(Movie Header Box) were not being carried over to the new CAMM track'stkhd(Track Header Box) andmdhd(Media Header Box). Both boxes were left with a default value of0.This change preserves those timestamps by:
creation_timeandmodification_timefrom the sourcemvhdinsidecamm_sample_generator2.create_camm_trak, which sets them on bothtkhdandmdhd.Test Plan
Added
test_camm_trak_carries_mvhd_timestampswhich:creation_time/modification_timein themvhd.tkhdandmdhdcarry the original timestamps.