fix: Tag protection now works correctly in GridTextEditor#2
Open
fix: Tag protection now works correctly in GridTextEditor#2
Conversation
Fixed bug where tag protection setting was not working because the logic was added to EditableGridTextEditor but the delegate creates GridTextEditor instances for target cells. Changes: - Added tag protection attributes to GridTextEditor.__init__ - Copied tag protection methods (_extract_tags, _tags_are_intact, _on_text_changed_with_tag_protection) to GridTextEditor - Added focusInEvent/focusOutEvent handlers to GridTextEditor - Ensured delegate is recreated when protection setting changes The tag protection feature now properly prevents tag modification when enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug where tag protection setting was not working because the logic was added to EditableGridTextEditor but the delegate creates GridTextEditor instances for target cells.
Changes:
The tag protection feature now properly prevents tag modification when enabled.