fix: resolve path duplication when workspace root differs from cwd#14
Merged
observerw merged 1 commit intolsp-client:mainfrom Jan 15, 2026
Merged
fix: resolve path duplication when workspace root differs from cwd#14observerw merged 1 commit intolsp-client:mainfrom
observerw merged 1 commit intolsp-client:mainfrom
Conversation
When running commands from a directory different from the LSP workspace root (e.g., in a Cargo workspace with nested crates), relative file paths were incorrectly duplicated. Example: `crates/foo/src/bar.rs` was resolved to `/path/crates/foo/crates/foo/src/bar.rs` Fix by converting relative paths to absolute paths in `create_locate()` before passing to lsp_client, which correctly handles absolute paths in its `as_uri()` method.
Contributor
|
Thank you! I'll take a look 😄 |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Resolve path duplication when workspace root differs from cwd
Problem
When running
lspcommands from a directory different from the LSP workspace root, relative file paths were incorrectly duplicated.For example, in a Cargo workspace with nested crates:
The path
crates/foowas duplicated because:crates/foo/src/bar.rs)find_client()discovers workspace root as/path/to/project/crates/foo(whereCargo.tomllives)lsp_client.as_uri()concatenates workspace root + relative path, causing duplicationSolution
Convert relative
file_pathto absolute path increate_locate()before passing tolsp_client. Theas_uri()method correctly handles absolute paths by checking if they fall within workspace folders.Changes
src/lsp_cli/cli/shared.py: Add path normalization increate_locate()Testing
Verified fix works in a Cargo workspace: