Skip to content

Conversation

mousheng
Copy link
Contributor

@mousheng mousheng commented Aug 9, 2023

add_weekPick_monthPick_quarterPick_yearPicker
image

@netlify
Copy link

netlify bot commented Aug 9, 2023

‼️ Deploy request for lowcoder-cloud rejected.

Name Link
🔨 Latest commit 79798e8

@@ -366,6 +366,11 @@ export const en = {
datePickerValueDesc: "Currently selected date",
datePickerFormattedValueDesc: "Formatted selected date according to the specified format",
datePickerTimestampDesc: "The currently selected timestamp of the date (s)",
weekPickerValueDesc: "The currently selected week in the year",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: "Currently selected week in the year."

@@ -366,6 +366,11 @@ export const en = {
datePickerValueDesc: "Currently selected date",
datePickerFormattedValueDesc: "Formatted selected date according to the specified format",
datePickerTimestampDesc: "The currently selected timestamp of the date (s)",
weekPickerValueDesc: "The currently selected week in the year",
monthPickerValueDesc: "The currently selected month",
monthPickerDaysInMonthDesc: "The currently days in the month",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: "Currently selected days in the month."

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit looks very good. Thank you.
Please look for the comments, so we can optimize the text a bit.

monthPickerValueDesc: "The currently selected month",
monthPickerDaysInMonthDesc: "The currently days in the month",
quarterPickerDaysInMonthDesc: "The currently selected quarter",
yearPickerDaysInMonthDesc: "The currently selected year",
dateRangeStartDesc: "Currently selected start date",
dateRangeEndDesc: "Currently selected end date",
dateRangeStartTimestampDesc: "The currently selected timestamp of the start date (s)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: "Currently selected timestamp of the start date(s)."

@FalkWolsky FalkWolsky closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants