image input size limit

[anandthakker]

Fantastic library--thanks for creating/maintaining!

I'm using it to resize some very large TIFs (> 1.5-2 billion pixels) and running into the input size limit. I'm able to use limitInputPixels() to increase the pixel limit, but the highest value that works for me is 2^32 - 1 = 2147483647. My undersatnding is that this is because on the C++ side, the limit is read as a 32-bit integer here. How feasible would it be to allow a larger value here?

[lovell]

Hello Anand, your understanding is correct. At the moment we're using 32-bit signed for which the max is 2^31-1.

It should be a one-line change (plus tests, of course) to switch this to 32-bit unsigned via ->Uint32Value(), allowing 2^32-1 = 4294967295.

Alternatively/additionally, we could modify limitInputPixels to also accept a boolean, where false = remove limit and true = reset to default limit.

(The limit exists to prevent resource hogging - see #115 for the background - although you do have to trust the image metadata.)

[anandthakker]

Thanks for the quick response, @lovell. I like the boolean option approach here, since, if someone's getting up above 2^31 pixels, it seems pretty likely that, like me, they actually just want no upper limit. I'll try that out; happy to submit it back as a PR if you're interested.

[lovell]

Great, PR gladly accepted, thank you for your kind offer!

[kentongray]

@anandthakker did you have any luck with a pull request? I'd love to have this feature

[anandthakker]

Ah, I unfortunately got pretty swamped soon after this, so I never did get
a chance to work up a PR. Sorry :-(
On Tue, Nov 24, 2015 at 8:14 PM kentongray notifications@github.com wrote:

@anandthakker https://github.com/anandthakker did you have any luck
with a pull request? I'd love to have this feature

—
Reply to this email directly or view it on GitHub
#250 (comment).

[kentongray]

@anandthakker no problem I know how that is! I'll make a stab at it unless @lovell has any other thoughts

[lovell]

@kentongray Thank you, go for it! Feel free to post questions here if you need help.