Colorize actionId, nodeId and client ids#128
Merged
ai merged 12 commits intologux:mainfrom Apr 24, 2022
bijela-gora:colorize-random
Merged
Colorize actionId, nodeId and client ids#128ai merged 12 commits intologux:mainfrom bijela-gora:colorize-random
ai merged 12 commits intologux:mainfrom
bijela-gora:colorize-random
Conversation
Member
|
Looks good. I will try to merge it when I will be back home. |
Contributor
Author
|
I'm sure that part of task about Client ID was not done
|
Contributor
Author
Member
|
Yes. But keep |
Contributor
Author
Member
|
What do you worry about? Use case:
|
Contributor
Author
|
Added the code to colorize client ids: https://github.com/logux/server/pull/128/files#diff-f6f47918804ef2911fa9330fa7f9d2b65f6b0fc61d49b4ab473f7af408d8698aR165 Added test for client ids: https://github.com/logux/server/pull/128/files#diff-997639ee9d9132d240f511dde5b22b433eff4b1846dde33b5ae122f0bf49afceR484 |
Contributor
Author
|
@ai should something else be done in scope of this MR? |
Member
|
Everything looks good. Sorry don't have a time to merge because I am preparing a talk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Link to the previous attempt to address the issue: #127