Skip to content

Colorize actionId, nodeId and client ids#128

Merged
ai merged 12 commits intologux:mainfrom
bijela-gora:colorize-random
Apr 24, 2022
Merged

Colorize actionId, nodeId and client ids#128
ai merged 12 commits intologux:mainfrom
bijela-gora:colorize-random

Conversation

@bijela-gora
Copy link
Copy Markdown
Contributor

Link to the previous attempt to address the issue: #127

@ai
Copy link
Copy Markdown
Member

ai commented Apr 18, 2022

Looks good. I will try to merge it when I will be back home.

@bijela-gora
Copy link
Copy Markdown
Contributor Author

bijela-gora commented Apr 18, 2022

I'm sure that part of task about Client ID was not done

Добавить Client ID в human-formatter записях об action.

https://cultofmartians.com/tasks/logux-colors-id.html#task

@bijela-gora
Copy link
Copy Markdown
Contributor Author

Screenshot from 2022-04-19 12-19-15

        Action: 
          id:   "1650363005200 1:LJn2x2r0:5duYiO0l 1"
        Meta:   
          clients:     ["1:LJn2x2r0"]
          server:      "server:UcCgMiWc"

This fields should also be colorized?

@ai
Copy link
Copy Markdown
Member

ai commented Apr 19, 2022

Yes. But keep server: prefix without color.

@bijela-gora
Copy link
Copy Markdown
Contributor Author

Screenshot from 2022-04-19 15-29-14

I feel a strong internal resistance to what I am doing. I hope you have a clear understanding of what needs to be done.

@ai
Copy link
Copy Markdown
Member

ai commented Apr 19, 2022

What do you worry about?

Use case:

  1. You have a long list of operations (50+)
  2. You need to quickly find a records about some action
  3. You remember that it has blue-green-red ID. Now you can scan log just by looking on colors.

@bijela-gora
Copy link
Copy Markdown
Contributor Author

@bijela-gora bijela-gora changed the title Colorize actionId and nodeId Colorize actionId, nodeId and client ids Apr 19, 2022
@bijela-gora
Copy link
Copy Markdown
Contributor Author

@ai should something else be done in scope of this MR?

@ai
Copy link
Copy Markdown
Member

ai commented Apr 22, 2022

Everything looks good. Sorry don't have a time to merge because I am preparing a talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants