Skip to content

Add option to skip header#69

Merged
gtsiolis merged 2 commits intomainfrom
george/add-option-to-skip-header
Mar 4, 2026
Merged

Add option to skip header#69
gtsiolis merged 2 commits intomainfrom
george/add-option-to-skip-header

Conversation

@gtsiolis
Copy link
Member

@gtsiolis gtsiolis commented Mar 3, 2026

See DES-152 for more context.

BEFORE AFTER
Screenshot 2026-03-04 at 00 52 54 Screenshot 2026-03-04 at 00 46 54

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d1dacecb-8700-4132-89d9-acc484323d69

📥 Commits

Reviewing files that changed from the base of the PR and between 3336c52 and 50aeb57.

📒 Files selected for processing (2)
  • internal/ui/app.go
  • internal/ui/run_logout.go

📝 Walkthrough

Walkthrough

The changes introduce an options pattern for the NewApp function to allow opting out of header rendering. A new AppOption type and withoutHeader() helper are added, enabling conditional header display. The run_logout.go function is updated to use this new option when creating an App instance.

Changes

Cohort / File(s) Summary
Header Rendering Option
internal/ui/app.go
Introduces AppOption functional type, adds withoutHeader() constructor, updates NewApp signature to accept variadic opts, adds hideHeader field to App struct, and guards header rendering with conditional logic.
Option Usage
internal/ui/run_logout.go
Updates NewApp invocation to pass withoutHeader() option when creating the app instance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add option to skip header' directly and concisely describes the main change—introducing a mechanism to optionally suppress header rendering via AppOption.
Description check ✅ Passed The description references DES-152 for context and includes before/after screenshots showing the logout command with and without the header, which clearly relates to the changeset's header-skip functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch george/add-option-to-skip-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@carole-lavillonniere carole-lavillonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a small clean-up, rest looks good!

@gtsiolis gtsiolis force-pushed the george/add-option-to-skip-header branch from ff3766c to 50aeb57 Compare March 4, 2026 11:06
@gtsiolis
Copy link
Member Author

gtsiolis commented Mar 4, 2026

Thanks for taking a look, @carole-lavillonniere! 👾

Applied changes from suggestions, will merge once checks pass.

@gtsiolis gtsiolis merged commit e26a3ee into main Mar 4, 2026
8 checks passed
@gtsiolis gtsiolis deleted the george/add-option-to-skip-header branch March 4, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants