Skip to content

Fix upgrade workflow#31

Merged
silv-io merged 3 commits intomainfrom
fix-go-upgrade-workflow
Feb 16, 2026
Merged

Fix upgrade workflow#31
silv-io merged 3 commits intomainfrom
fix-go-upgrade-workflow

Conversation

@silv-io
Copy link
Member

@silv-io silv-io commented Feb 13, 2026

The new upgrade workflow installed the current go version to upgrade the go version, which doesn't work in CI by the looks of it (works locally though).

Should've done a test run before merging. Fixed it now and confirmed with test runs that it will work in #32 and #33

@silv-io silv-io marked this pull request as ready for review February 13, 2026 19:28
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updated the weekly Go upgrade GitHub Actions workflow to use the stable Go version with check-latest enabled, add author/committer bot fields to PR creation, and replace delete-branch with token-based authentication and explicit reviewers.

Changes

Cohort / File(s) Summary
Go Upgrade Workflow Configuration
.github/workflows/weekly-go-upgrade.yml
Switched Go setup from go-version-file: go.mod to go-version: stable with check-latest: true; added author and committer fields to the create-pull-request step; removed delete-branch: true and added token: ${{ secrets.PRO_ACCESS_TOKEN }} and reviewers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • carole-lavillonniere
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix upgrade workflow' is directly related to the changeset, which fixes the Go upgrade workflow by correcting the version setup and CI configuration.
Description check ✅ Passed The description is related to the changeset, explaining that it fixes an issue in the upgrade workflow where the wrong Go version was being used in CI.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-go-upgrade-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

labels: dependencies
delete-branch: true
token: ${{ secrets.PRO_ACCESS_TOKEN }}
reviewers: silv-io,carole-lavillonniere
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we pick up the users from codeowners file instead?

@silv-io silv-io merged commit 7c5bb3b into main Feb 16, 2026
6 of 7 checks passed
@silv-io silv-io deleted the fix-go-upgrade-workflow branch February 16, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants