[cinnamon/windowManager] PERF: Batch workspace-switch animations #13421
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent compositor overload when switching workspaces with many windows. - Add animation queue with MAX_CONCURRENT_ANIMATIONS = 10 limit - Process animations in batches instead of starting all simultaneously - Each completed animation triggers the next from queue Without batching, 30+ windows create 30+ parallel Clutter timelines, causing frame drops and compositor stutter.
Member
|
Your use-case is exceptional - let's just skip the animation if there are more than so many windows open. I don't like this added complexity here. This won't ever be an issue for most users. |
Author
|
Thats true, not so special if you think about 10 or 20, but it is also more snappy if there are only a few windows on standard 4 workspaces. I think it will also count on older hardware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent compositor "overload" when switching workspaces with many windows.
Without batching, 100+ windows create 100+ parallel Clutter timelines, causing frame drops and compositor stutter.
I had this problem because I often have more than 100 windows open across 12 workspaces. (Really? Yes, really.)
With the fix, switching between workspaces is noticeably faster and smoother.
Cheers, Carsten