Skip to content

[WIP] gwl: Add overflow support through sliding #13352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anaximeno wants to merge 10 commits into
base: master
Choose a base branch
from
+417 −29
Open

[WIP] gwl: Add overflow support through sliding #13352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
855298c
gwl: Add initial overflow support through sliding
anaximeno Jan 10, 2026
a9fed70
gwl: Scroll to focused app when a new one is added or when changing w…
anaximeno Jan 11, 2026
7dfdf10
gwl: Avoid trying to remove slide timer multiple times
anaximeno Jan 11, 2026
b580dd1
gwl: Properly integrate with the scroll-behavior settings
anaximeno Jan 11, 2026
2beccea
gwl: Avoid trying to remove the scroll to focused app deboucer timer …
anaximeno Jan 11, 2026
4bb4ad2
gwl: Listen to the scrollBox allocation signal to update the scroll b…
anaximeno Jan 11, 2026
5da320c
gwl: Make sure to scroll to the focused app group on workspace switched
anaximeno Jan 11, 2026
9de8020
gwl: Refactor the scroll logic to its own class
anaximeno Jan 17, 2026
a5d98fc
gwl: Improve scroll to item implementation
anaximeno Jan 17, 2026
5f27137
gwl: Extract app group scroll box to its own module
anaximeno Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/applet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class PinnedFavs {
const currentWorkspace = this.params.state.trigger('getCurrentWorkspace');
const newFavorites = [];
let refActorFound = false;
currentWorkspace.actor.get_children().forEach( (actor, i) => {
currentWorkspace.container.get_children().forEach( (actor, i) => {
const appGroup = currentWorkspace.appGroups.find( appGroup => appGroup.actor === actor );
if (!appGroup) return;
const {app, appId, isFavoriteApp} = appGroup.groupState;
Expand Down Expand Up @@ -799,12 +799,25 @@ class GroupedWindowListApplet extends Applet.Applet {
if(this.state.dragging.posList === null){
this.state.dragging.isForeign = !(source instanceof AppGroup);
this.state.dragging.posList = [];
currentWorkspace.actor.get_children().forEach( child => {

let offset = 0;
if (this.state.isHorizontal) {
offset = currentWorkspace.container.translation_x;
if (currentWorkspace.startButton.visible)
offset += currentWorkspace.startButton.width;
} else {
offset = currentWorkspace.container.translation_y;
if (currentWorkspace.startButton.visible)
offset += currentWorkspace.startButton.height;
}

currentWorkspace.container.get_children().forEach( child => {
let childPos;
let box = child.get_allocation_box();
if(rtl_horizontal)
childPos = this.actor.width - child.get_allocation_box()['x1'];
childPos = this.actor.width - (box.x1 + offset);
else
childPos = child.get_allocation_box()[axis[1]];
childPos = box[axis[1]] + offset;
this.state.dragging.posList.push(childPos);
});
}
Expand Down Expand Up @@ -833,21 +846,21 @@ class GroupedWindowListApplet extends Applet.Applet {

if(this.state.dragging.isForeign) {
if (this.state.dragging.dragPlaceholder)
currentWorkspace.actor.set_child_at_index(this.state.dragging.dragPlaceholder.actor, pos);
currentWorkspace.container.set_child_at_index(this.state.dragging.dragPlaceholder.actor, pos);
else {
const iconSize = this.getPanelIconSize() * global.ui_scale;
this.state.dragging.dragPlaceholder = new DND.GenericDragPlaceholderItem();
this.state.dragging.dragPlaceholder.child.width = iconSize;
this.state.dragging.dragPlaceholder.child.height = iconSize;
currentWorkspace.actor.insert_child_at_index(
currentWorkspace.container.insert_child_at_index(
this.state.dragging.dragPlaceholder.actor,
this.state.dragging.pos
);
this.state.dragging.dragPlaceholder.animateIn();
}
}
else
currentWorkspace.actor.set_child_at_index(source.actor, pos);
currentWorkspace.container.set_child_at_index(source.actor, pos);
}

if(this.state.dragging.isForeign)
Expand Down
1 change: 1 addition & 0 deletions files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const constants = {
FLASH_INTERVAL: 500,
FLASH_MAX_COUNT: 4,
RESERVE_KEYS: ['willUnmount'],
SCROLL_TO_APP_DEBOUNCE_TIME: 100,
TitleDisplay: {
None: 1,
App: 2,
Expand Down
Loading
Loading