-
Notifications
You must be signed in to change notification settings - Fork 61
ci: move config file #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move config file #530
Conversation
Reviewer's GuideThe File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richm - I've reviewed your changes - here's some feedback:
- The PR description could briefly explain the new Sourcery configuration setup, such as if it now uses a default path or if this specific config is no longer needed.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - uses: sourcery-ai/action@v1 | ||
| with: | ||
| token: ${{ secrets.SOURCERY_TOKEN }} | ||
| config: .github/config/sourcery.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (bug_risk): Removal of the config option appears intentional, verify that default settings align with expectations.
Verify the Sourcery action uses the intended default config and that removing the config entry won’t introduce unexpected behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
- Coverage 16.54% 10.72% -5.83%
==========================================
Files 2 8 +6
Lines 284 1949 +1665
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1740 +1503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
CI: