fix: there is no kmod-kvdo on EL10 and later #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
- Coverage 16.54% 10.72% -5.83%
==========================================
Files 2 8 +6
Lines 284 1949 +1665
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1740 +1503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cause: The blivet module adds `kmod-kvdo` as a required package on platforms that do not have the pacakge. Consequence: The package fails to be installed on EL10 and causes the role to fail with an error. Fix: Ensure `kmod-kvdo` is not added as a required package on EL10. Result: The storage role does not give an error when using VDO on EL10 and later. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
changed the title
Contributor
Author
|
[citest] |
Contributor
Author
|
[citest_bad] |
spetrosi
approved these changes
Mar 4, 2025
vojtechtrefny
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The blivet module adds
kmod-kvdoas a required package onplatforms that do not have the pacakge.
Consequence: The package fails to be installed on EL10 and causes
the role to fail with an error.
Fix: Ensure
kmod-kvdois not added as a required package on EL10.Result: The storage role does not give an error when using VDO
on EL10 and later.
Signed-off-by: Rich Megginson rmeggins@redhat.com