test: [UIE-10834] - Fix Image test failures by mocking feature flag#13572
Merged
jdamore-linode merged 4 commits intolinode:developfrom Apr 10, 2026
Merged
Conversation
jdamore-linode
requested review from
abailly-akamai,
dmcintyr-akamai and
pmakode-akamai
and removed request for
a team
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
pmakode-akamai
approved these changes
Apr 10, 2026
pmakode-akamai
added
Add'tl Approval Needed
dmcintyr-akamai
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This works around the Cypress test failures in Image related tests that started failing after enabling the
privateImageSharingfeature flag indevelopthis morning. This is only a quick workaround, and proper test coverage for Private Image Sharing-enabled flows will be pursued in our Playwright test suite.Changes 🔄
privateImageSharingflag to be disabled in failing testsScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
I'd like to merge these as soon as possible once we confirm the tests pass as a result of these changes.
How to test 🧪
We can rely on CI for this
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅