upcoming: [UIE-10430] - Reserved IP: Implement Landing Screen.#13549
Merged
grevanak-akamai merged 6 commits intolinode:developfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the Reserved IPs landing experience (table + row rendering) and adds supporting MSW “CRUD preset” wiring and seed data so the page can be exercised locally behind the feature flag.
Changes:
- Added Reserved IPs landing UI (table, row rendering, action menu) with pagination and ordering driven by query params/preferences.
- Extended MSW mock state/types and added Reserved IP list handler + seeder to populate mock data.
- Wired Reserved IP mocks/seeders into the baseline CRUD preset and DevTools seed list.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/manager/src/mocks/types.ts | Adds “Reserved IPs” to CRUD groups/IDs and adds reservedIPs to MockState. |
| packages/manager/src/mocks/presets/crud/seeds/networking.ts | Adds reservedIPSeeder using reservedIPsFactory and IndexedDB seed state. |
| packages/manager/src/mocks/presets/crud/seeds/index.ts | Registers reservedIPSeeder in dbSeeders. |
| packages/manager/src/mocks/presets/crud/networking.ts | Adds reservedIPsCrudPreset to expose Reserved IP handlers in CRUD preset. |
| packages/manager/src/mocks/presets/crud/handlers/networking.ts | Adds MSW GET handler for /v4beta/networking/reserved/ips. |
| packages/manager/src/mocks/presets/baseline/crud.ts | Includes networking and reserved IP handlers in the baseline CRUD preset. |
| packages/manager/src/mocks/mockState.ts | Initializes reservedIPs: [] in the empty mock store. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingTable.tsx | New table component rendering Reserved IPs list with sorting + pagination. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingRow.tsx | New row renderer with assigned-entity link logic and tag overflow handling. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.tsx | Hooks up queries/pagination/sorting and renders empty/loading/error states. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsActionMenu.tsx | Adds action menu skeleton for Edit/Unreserve actions. |
| packages/manager/src/factories/networking.ts | Adds reservedIPsFactory seed data for Reserved IPs (regions/tags/assigned entities). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.tsx
Outdated
Show resolved
Hide resolved
4aba464 to
e90983d
Compare
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingTable.tsx
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingRow.test.tsx
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.tsx
Show resolved
Hide resolved
packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingTable.tsx
Show resolved
Hide resolved
e0a76d1 to
8dd1752
Compare
grevanak-akamai
approved these changes
Apr 8, 2026
ff9e625 to
647d13a
Compare
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #10 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
tvijay-akamai
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Implement Reserved IP Landing Table alongwith CRUD MSW mock setup.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅